Skip to content

docs(assembly): clarify div vs u32div semantics#2925

Closed
cwhitak3r wants to merge 1 commit into0xMiden:nextfrom
cwhitak3r:docs/field-div-vs-u32div-warning
Closed

docs(assembly): clarify div vs u32div semantics#2925
cwhitak3r wants to merge 1 commit into0xMiden:nextfrom
cwhitak3r:docs/field-div-vs-u32div-warning

Conversation

@cwhitak3r
Copy link
Copy Markdown

Closes #2911, make field-division warnings explicit and add cross-references between div and u32div to avoid integer-division confusion.

@huitseeker huitseeker requested a review from plafer March 28, 2026 09:12
Copy link
Copy Markdown
Collaborator

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Collaborator

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign commits and cleanup the Changelog, otherwise LGTM

Comment thread CHANGELOG.md
#### Bug Fixes

- Reverted `InvokeKind::ProcRef` back to `InvokeKind::Exec` in `visit_mut_procref` and added an explanatory comment (#2893).
- Fixed `FastProcessor` so `after_exit` trace decorators execute when tracing is enabled without debug mode, and added a tracing-only regression test.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right PR for this actually (#2922), please clean up.

@huitseeker
Copy link
Copy Markdown
Collaborator

Closing for inacitivty

@huitseeker huitseeker closed this Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strengthen field division warning in assembly docs

2 participants